Re: [PATCH 8/9] ASoC: SOF: imx: merge imx8 and imx8ulp drivers

[Frank Li <Frank.li@xxxxxxx>]

On Tue, Feb 04, 2025 at 06:46:15PM +0200, Laurentiu Mihalcea wrote:
>
> (snip)
>
> >>  IMX_SOF_DEV_DESC(imx8, sof_imx8_machs, &imx8_chip_info, &sof_imx8_ops, imx_ops_init);
> >>  IMX_SOF_DEV_DESC(imx8x, sof_imx8_machs, &imx8x_chip_info, &sof_imx8_ops, imx_ops_init);
> >>  IMX_SOF_DEV_DESC(imx8m, sof_imx8_machs, &imx8m_chip_info, &sof_imx8_ops, imx_ops_init);
> >> +IMX_SOF_DEV_DESC(imx8ulp, sof_imx8_machs, &imx8ulp_chip_info, &sof_imx8_ops, imx_ops_init);
> >>
> >>  static const struct of_device_id sof_of_imx8_ids[] = {
> >>  	{
> >> @@ -339,6 +448,10 @@ static const struct of_device_id sof_of_imx8_ids[] = {
> >>  		.compatible = "fsl,imx8mp-dsp",
> >>  		.data = &IMX_SOF_DEV_DESC_NAME(imx8m),
> >>  	},
> >> +	{
> >> +		.compatible = "fsl,imx8ulp-dsp",
> >> +		.data = &IMX_SOF_DEV_DESC_NAME(imx8ulp),
> >> +	},
> > Can you put imx8ulp_dai into driver data to avoid of_device_is_compatible()
> > logic?
> >
> > Frank
>
> should be able to add it to "struct imx_chip_info"

Yes, you try it.  Generally if use .data, needn't check compatible in
driver. .data should include all difference formation for difference
compatible string.

Frank


>