Re: [PATCH] ALSA: pcm: use new array-copying-wrapper

[Chenyuan Yang <chenyuan0y@xxxxxxxxx>]

Hi Takashi,

It looks great to me! Thanks so much for your help!

Best,
Chenyuan

On Tue, Jan 28, 2025 at 1:49 AM Takashi Iwai <tiwai@xxxxxxx> wrote:
>
> On Mon, 27 Jan 2025 17:06:55 +0100,
> yangchenyuan wrote:
> >
> > From: Chenyuan Yang <chenyuan0y@xxxxxxxxx>
> >
> > This is found by our static analysis tool.
> >
> > pcm_native.c utilizes memdup_user() to copy an array from userspace.
> >
> > There is a new wrapper, specifically designed for copying arrays. Use
> > this one instead.
> >
> > This is similar to the
> > commit 3e91a38de1dc ("fbdev: viafb: use new array-copying-wrapper").
> >
> > Fixes: 67616feda99e ("ALSA: pcm: Unify ioctl functions for playback and capture streams")
>
> This use of Fixes tag is misleading: the original code is correct, per
> se, and the original commit was 4.14, where it had no no
> memdup_array_user() available (introduced since 6.7).
>
> So I applied with the drop of Fixes tag.
>
>
> thanks,
>
> Takashi