On Mon, Jan 20, 2025 at 03:31:09PM +0530, Vijendar Mukunda wrote: > This patch adds common PCI driver to bind to this device and get PCI > resources for ACP7.0 & ACP7.1 platforms. > + ret = pci_request_regions(pci, "AMD ACP6.2 audio"); > + if (ret < 0) { > + dev_err(&pci->dev, "pci_request_regions failed\n"); > + goto disable_pci; > + } Looks like there's a cut'n'paste that needed to be updated here! I'd suggest there might be some chance for code sharing, but I suspect the amount of code is so trivial that it's not really worth it.
Attachment:
signature.asc
Description: PGP signature
- Follow-Ups:
- Re: [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
- From: Mukunda,Vijendar
- Re: [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
- References:
- [PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support
- From: Vijendar Mukunda
- [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
- From: Vijendar Mukunda
- [PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support
- Prev by Date: Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper
- Next by Date: Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper
- Previous by thread: [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
- Next by thread: Re: [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
- Index(es):