Re: [PATCH v7 1/2] ALSA: FCP: Add Focusrite Control Protocol driver

["Geoffrey D. Bennett" <g@xxxxx>]

Hi Takashi,

A couple of questions for clarification:

On Thu, Jan 16, 2025 at 04:03:48PM +0100, Takashi Iwai wrote:
> On Thu, 16 Jan 2025 10:03:35 +0100,
> Geoffrey D. Bennett wrote:
[...]
> > +#define SNDRV_CTL_TLVT_LABELS		0x110	/* channel labels */
> 
> IMHO, the data definition looks too ambiguous here to be put as a
> public API.  It can be also a more specific name such as
> *_CHANNEL_LABELS, too.

Do you mean e.g. SNDRV_CTL_TLVT_FCP_CHANNEL_LABELS ?

But still define in include/uapi/sound/tlv.h?

And 0x110 is okay to use?

> [...]

Other comments noted and will update accordingly in v8.

Thanks,
Geoffrey.