Re: [PATCH 07/13] ASoC: Intel: avs: Add MODULE_FIRMWARE to inform about FW

[Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxx>]

> +MODULE_FIRMWARE("intel/skl/dsp_basefw.bin");
> +MODULE_FIRMWARE("intel/apl/dsp_basefw.bin");
> +MODULE_FIRMWARE("intel/cnl/dsp_basefw.bin");
> +MODULE_FIRMWARE("intel/icl/dsp_basefw.bin");
> +MODULE_FIRMWARE("intel/jsl/dsp_basefw.bin");
> +MODULE_FIRMWARE("intel/lkf/dsp_basefw.bin");

Lakefield? Is this really a supported platform? It was EOL'ed a year after launch, wasn't it?

> +MODULE_FIRMWARE("intel/tgl/dsp_basefw.bin");
> +MODULE_FIRMWARE("intel/ehl/dsp_basefw.bin");
> +MODULE_FIRMWARE("intel/adl/dsp_basefw.bin");
> +MODULE_FIRMWARE("intel/adl_n/dsp_basefw.bin");

If you start listing the variants of ADL, then shouldn't you also list the variants of TGL?
Same for CNL, there are multiple variants, not to mention different signing keys.