[bug report] ASoC: soc-card: add snd_soc_card_set_bias_level()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hello Kuninori Morimoto,

This is a semi-automatic email about new static checker warnings.

Commit 39caefda0a30 ("ASoC: soc-card: add
snd_soc_card_set_bias_level()") from May 28, 2020, leads to the
following Smatch complaint:

    sound/soc/soc-dapm.c:733 snd_soc_dapm_set_bias_level()
    warn: variable dereferenced before check 'card' (see line 729)

sound/soc/soc-dapm.c
   728	
   729		ret = snd_soc_card_set_bias_level(card, dapm, level);
                                                  ^^^^
The patch removed a NULL check before this dereference.

   730		if (ret != 0)
   731			goto out;
   732	
   733		if (!card || dapm != &card->dapm)
                     ^^^^
But this NULL check is still there

   734			ret = snd_soc_dapm_force_bias_level(dapm, level);
   735	

regards,
dan carpenter




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux