Re: [PATCH v2] ASoC: soc-core: add snd_soc_dapm_add_routes_with_card()

[Amadeusz Sławiński <amadeuszx.slawinski@xxxxxxxxxxxxxxx>]

On 1/8/2025 4:06 AM, Kuninori Morimoto wrote:
> Some device want to ignore snd_soc_dapm_add_routes() error, thus
> card->disable_route_checks flags had been added for such purpose. Because
> of this, ASoC has duplicate code for it. Let's adds new
> snd_soc_dapm_add_routes_with_card(), and share the error message handling.
>
> We don't need to indicate error message on this function, because it will
> be indicated from snd_soc_dapm_add_route().
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---

card->disable_route_checks is a leftover from skylake driver which had 
partial routes in some topologies, as skylake driver was removed, 
perhaps we can remove the field altogether?

Quick grep shows that there is only one board left which sets it:
sound/soc/intel/boards/skl_hda_dsp_generic.c: 
card->disable_route_checks = true;
and it only does it after checking that parent driver isn't SOF, and as 
skylake driver was removed it is dead code (it was shared between SOF 
and skylake drivers).

As such I would recommend removing whole thing altogether ;)