Re: [RFC PATCH v1 2/2] ASoC: dapm: add support for preparing streams

[Mark Brown <broonie@xxxxxxxxxx>]

On Mon, Jan 06, 2025 at 03:34:01PM +0100, Jerome Brunet wrote:
> On Mon 06 Jan 2025 at 15:28, Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
> > On Mon 06 Jan 2025 at 15:13, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote:

> >>  	case SND_SOC_DAPM_POST_PMU:
> >> +		snd_soc_dapm_widget_for_each_sink_path(w, path) {
> >> +			sink = path->sink->priv;
> >> +
> >> +			snd_soc_dai_prepare(sink, substream);

> I initially missed it but I think you should do that on the source path
> too

> On Amlogic, the cpu side of the link does not have a .prepare() callback
> but it would be incorrect to do the codec side only if it did.

Yes, symmetry seems sensible.

Attachment: signature.asc
Description: PGP signature