Re: [CFT][PATCH] fix descriptor uses in sound/core/compress_offload.c

[Takashi Iwai <tiwai@xxxxxxx>]

On Thu, 26 Dec 2024 23:17:26 +0100,
Al Viro wrote:
> 
> On Thu, Dec 26, 2024 at 09:31:22PM +0000, Al Viro wrote:
> > On Thu, Dec 26, 2024 at 08:00:18PM +0100, Jaroslav Kysela wrote:
> > 
> > >   I already made almost similar patch:
> > > 
> > > https://lore.kernel.org/linux-sound/20241217100726.732863-1-perex@xxxxxxxx/
> > 
> > Umm...  The only problem with your variant is that dma_buf_get()
> > is wrong here - it should be get_dma_buf() on actual objects,
> > and it should be done before fd_install().
> 
> Incremental on top of what just got merged into mainline:
> 
> Grab the references to dmabuf before moving them into descriptor
> table - trying to do that by descriptor afterwards might end up getting
> a different object, with a dangling reference left in task->{input,output}
> 
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Could you resubmit this one as a formal patch to be merged?
Thanks!


Takashi