Re: [PATCH V3 2/2] ASoC: codecs: Add aw88083 amplifier driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, 24 Dec 2024 10:56:55 +0100 luca.ceresoli@xxxxxxxxxxx wrote:
> On Tue, 24 Dec 2024 11:18:23 +0800
> wangweidong.a@xxxxxxxxxx wrote:

>> From: Weidong Wang <wangweidong.a@xxxxxxxxxx>
>> 
>> The driver is for amplifiers aw88083 of Awinic Technology
>> Corporation. The AW88083 is an intelligent digital audio
>> amplifier with low noise.
>> 
>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202412201745.fBpf3Ui5-lkp@xxxxxxxxx/

> You should not add these two lines. From the kernel test robot report:

>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202412201745.fBpf3Ui5-lkp@xxxxxxxxx/

> If you think about someone looking at git log in the future, they will
> see the final version of your patch, they will never see v2. So the
> final version (v3, v4, whatever) is not fixing any error as the error in
> v2 will never be applied.

hi Luca,

Thank you very much for your review.
I will remove these two lines in PATCH V4

Best regards
Weidong Wang




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux