Re: [PATCH v2 3/5] ASoC: dt-bindings: audio-graph-card2: add widgets and hp-det-gpios support

[Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>]

Hi

> >> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
> >> index f943f90d8b15..94588353f852 100644
> >> --- a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
> >> +++ b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
> >> @@ -37,6 +37,10 @@ properties:
> >>    codec2codec:
> >>      type: object
> >>      description: Codec to Codec node
> >> +  hp-det-gpios:
> >> +    $ref: audio-graph.yaml#/properties/hp-det-gpios
> >> +  widgets:
> >> +    $ref: audio-graph.yaml#/properties/widgets
>
> > why not direct ref Documentation/devicetree/bindings/sound/audio-graph.yaml
> > and define these again here.
>
> We don't actually want all the properties from 'audio-graph.yaml'
> (for the moment at least). Also ref-ing 'audio-graph.yaml' will make the
> 'dais' property required, which is not targeted in this patch.
> Maybe Kuninori Morimoto can comment more on this.

I'm not a DT yaml expert, but audio-graph.yaml is for audio-graph-card and
its custom card. unfortunately audio-graph-card2 is using different style,
so ref audio-graph.yaml on audio-graph-card2 is impossible, or makes yaml
more complex.

Thank you for your help !!

Best regards
---
Kuninori Morimoto