Re: [PATCH v3 07/25] ASoC: renesas: rz-ssi: Use only the proper amount of dividers

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Claudiu,

On Mon, Dec 9, 2024 at 2:32 PM Claudiu Beznea <claudiu.beznea@xxxxxxxxx> wrote:
> On 09.12.2024 15:22, Geert Uytterhoeven wrote:
> > On Wed, Nov 13, 2024 at 2:36 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> >> -       static s8 ckdv[16] = { 1,  2,  4,  8, 16, 32, 64, 128,
> >> -                              6, 12, 24, 48, 96, -1, -1, -1 };
> >> +       static s8 ckdv[] = { 1,  2,  4,  8, 16, 32, 64, 128, 6, 12, 24, 48, 96 };
> >
> > "u8", as 128 doesn't fit in s8 (why doesn't the compiler complain?).
>
> Failed to notice that. Thank you for pointing it! I saw no compiler
> complains, though.

Me neither. And the code has been storing 128 in s8 since the beginning...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds