Re: [PATCH v7 12/14] arm64: dts: qcom: sdm845-starqltechn: add initial sound support

[Dzmitry Sankouski <dsankouski@xxxxxxxxx>]

чт, 5 дек. 2024 г. в 19:45, Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>:
>
> On 4.12.2024 10:34 PM, Dzmitry Sankouski wrote:
> > Add support for sound (headphones and mics only)
> > Also redefine slpi reserved memory, because adsp_mem overlaps with
> > slpi_mem inherited from sdm845.dtsi.
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
> >
> > ---
>
> [...]
>
>
> > +     audio-routing = "RX_BIAS", "MCLK",
> > +                     "AMIC2", "MIC BIAS2",   /* Headset Mic */
> > +                     "AMIC3", "MIC BIAS2",   /* FMLeft Tx */
> > +                     "AMIC4", "MIC BIAS2",   /* FMRight Tx */
>
> FM - FM radio, or "Front Mic" / earpiece?

FM radio. I'll fix the comment to avoid ambiguity.

>
> > +                     "DMIC0", "MCLK",        /* Bottom Mic */
> > +                     "DMIC0", "MIC BIAS1",
> > +                     "DMIC2", "MCLK",        /* Top Mic */
>
> Looking at some pictures, I'm guessing these two are the little holes
> in the top/bottom edges of the device?

Yes.

-- 
Best regards and thanks for review,
Dzmitry