Re: [PATCH] ALSA: control: Avoid WARN() for symlink errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Mon, 09 Dec 2024 09:39:25 +0100,
Takashi Iwai wrote:
> 
> Using WARN() for showing the error of symlink creations don't give
> more information than telling that something goes wrong, since the
> usual code path is a lregister callback from each control element
> creation.  More badly, the use of WARN() rather confuses fuzzer as if
> it were serious issues.
> 
> This patch downgrades the warning messages to use the normal pr_warn()
> instead of WARN().

There is no reason to stick with the warning level.  It'd be better
with the normal dev_err().  Will resubmit v2.


Takashi




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux