Re: [PATCH v2] ASoC: pcm3168a: Add option to force clock consumer

[Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>]

Hi Stephen

> > You should use one of the audio-graph-card bindings for anything new.

Using audio-graph-card is good idea, but all
simple_card/audio-graph-card/audio-graph-card2 are using same logic around here.
So, you will have same issue on audio-graph-card too.

> > > Basically, simple_card appears to set the CPU as producer if you
> > > don't specify a producer. I am not sure whether this is a bug.  
> > 
> > Well, if nothing is configured it's got to pick a default?

If my understand was correct, your issue can be solved...

	dailink_out_master: simple-audio-card,dai-link@0 {
		...
=>		pcm3168_playback: codec {
			...
		};
	};
	dailink_in_slave: simple-audio-card,dai-link@1 {
=>		bitclock-master = <&pcm3168_playback>;
=>		frame-master    = <&pcm3168_playback>;
		...
	};

asoc_simple_parse_daifmt() is just checking where the node was codec node
or not. So, if bitclock-master/frame-master were produced, but was not codec,
both CPU/Codec can be consumer ?

# Clock producer/consumer settings is very confusable, because it was
# Codec base, and has flip, etc...

Thank you for your help !!

Best regards
---
Kuninori Morimoto