Re: [PATCH] ALSA: cmipci: Modify the incorrect format specifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Fri, 06 Dec 2024 03:16:47 +0100,
liujing wrote:
> 
> Replace %d with %u in snprintf() because it is "unsigned int".
> 
> Signed-off-by: liujing <liujing@xxxxxxxxxxxxxxxxxxxx>

I applied this one, but please keep in mind that we don't have to
convert all those cases blindly.  The code there is correct even with
"%d", as the value can't be a negative value.

That said, if you keep working on a similar case, you'd better study
the code more closely and judge whether it really "fixes" any real
bug or not, before submitting patches at the next time.


thanks,

Takashi




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux