Re: [PATCH v30 00/30] Introduce QC USB SND audio offloading support

[Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>]

On Tue, Dec 03, 2024 at 05:17:48PM +0100, Cezary Rojewski wrote:
> On 2024-12-01 4:14 AM, Pierre-Louis Bossart wrote:
> > Sorry to chime in late, I only look at email occasionally.
> > 
> 
> ...
> 
> > My Reviewed-by tags were added in the last updates. I am not sure if anyone else at Intel had the time to review this large patchset.
> > 
> > > I believe Amadeusz was still against having the two card design, and wants the routing to automatically happen when playback happens on the sound card created by the USB SND layer.  However, even with that kind of implementation, the major pieces brought in by this series should still be relevant, ie soc-usb and the vendor offload driver.  The only thing that would really change is adding a path from the USB SND PCM ops to interact with the ASoC entities.  Complexity-wise, this would obviously have a good amount of changes to the USB SND/ASoC core drivers.  Some things I can think of that we'd need to introduce:
> > 
> > The notion of two cards was agreed inside Intel as far back as 2018, when Rakesh first looked at USB offload.
> 
> 
> Well, I believe a lot has changed since then, not sure if USB Audio Offload
> (UAOL) was even stable on the Windows solution back then. Obviously we want
> to incorporate what we have learned during all that time into our solution
> before it lands on upstream.

Great, can you help review this series please?

thanks,

greg k-h