Re: [PATCH 0/2] Introduce Poly/Plantronics mute event support

[Terry Junge <linuxhid@xxxxxxxxxxxxxxxxxxxxxx>]

On 11/25/24 12:55 AM, Takashi Iwai wrote:
> On Sun, 24 Nov 2024 21:32:39 +0100,
> Terry Junge wrote:
>>
>> Hi Jiri and Takashi,
>>
>> I'm not sure how it works with two different maintained trees
>> but this patch set needs to be applied and flow upstream together.
>>
>> If the HID patch is applied without the ALSA patch then mute sync
>> issues will occur with multiple Poly/Plantronics product families.
> 
> Both patches can be applied individually, and even if only one of them
> is applied, it won't hurt.  So I guess both subsystems can take the
> corresponding one at any time.
> 

Hi Takashi,

I've tested out the behavior with each patch individually applied and
have found that, IMHO, the mute functionality and synchronization is
worse than the current behavior with neither patch. However, with both
patches applied the mixer UI microphone mute control and the headset
mute button are fully synchronized.

There must be a way that both patches can be tied together and be
applied simultaneously.

If it would help, and be allowed, I can submit a single patch that
contains both changes.

Thanks,
Terry

> 
> thanks,
> 
> Takashi
> 
>>
>> This patch set was tested by Wade and myself with multiple
>> Poly/Plantronics product family headsets.
>>
>> Hi Wade,
>>
>> Please feel free to add your Signed-off-by: and/or Tested-by: tags,
>> as you see fit.
>>
>> Thanks,
>> Terry
>>
>> Terry Junge (2):
>>   HID: hid-plantronics: Add mic mute mapping and generalize quirks
>>   ALSA: usb-audio: Add quirk for Plantronics headsets to fix control
>>     names
>>
>>  drivers/hid/hid-plantronics.c | 135 ++++++++++++++++------------------
>>  sound/usb/mixer_quirks.c      |  35 +++++++++
>>  2 files changed, 100 insertions(+), 70 deletions(-)
>>
>>
>> base-commit: 28eb75e178d389d325f1666e422bc13bbbb9804c
>> -- 
>> 2.43.0
>>