Re: [PATCH v3 2/5] ASoC: dt-bindings: wcd937x-sdw: Add static channel mapping support

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Tue, Nov 26, 2024 at 10:12:57PM +0530, Mohammad Rafi Shaik wrote:
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
> index d3cf8f59cb23..7893b1c1f80b 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
> @@ -58,6 +58,44 @@ properties:
>      items:
>        enum: [1, 2, 3, 4, 5]
>  
> +  qcom,tx-channel-mapping:
> +    description: |
> +      Specifies static channel mapping between slave and master tx port
> +      channels.
> +      In the order of slave port channels which is adc1, adc2, adc3,
> +      dmic0, dmic1, mbhc, dmic2, dmic3, dmci4, dmic5, dmic6, dmic7.
> +      The channel map index values are fixed values.
> +      SWRM_CH1 ==> 1
> +      SWRM_CH2 ==> 2
> +      SWRM_CH3 ==> 4
> +      SWRM_CH4 ==> 8

I am surprised to see here again 1/2/4/8. My comments were not
addressed. I think we agreed during our off-list talk that you will use
1, 2, 3 and 4.

> +
> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    minItems: 12
> +    maxItems: 12
> +    additionalItems: false
> +    items:
> +      enum: [1, 2, 4, 8]

Best regards,
Krzysztof