Re: [PATCH] ASoC: simple-card-utils: Unify clock direction by clk_direction

[Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>]

Hi Mark

> Original sample-card assumes SND_SOC_CLOCK_IN is used for
> snd_soc_dai_set_sysclk(), but someday, Codec uses SND_SOC_CLOCK_IN
> and CPU uses SND_SOC_CLOCK_OUT at hw_params(), and dai->clk_direction
> is used at simple_init_dai().
> 
> There is no uniformity today. Let's use dai->clk_direction for all cases.
> 
> Fortunately, almost all DAI doesn't care about "dir"
> (= SND_SOC_CLOCK_IN/OUT) in .set_sysclk callback function (which is called
> in snd_soc_dai_set_sysclk()), so this patch has no effect in such DAIs.
> 
> But this patch might breaks some existing Sound Card. Use
> "system-clock-direction-out" property if it needs to use SND_SOC_CLOCK_OUT
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---
> Request to have Tested-by

I'm sorry. I notice this patch has bug.
Please drop this.


Thank you for your help !!

Best regards
---
Kuninori Morimoto