Re: [PATCH 1/3] ASoC: dt-bindings: rockchip,rk3308-codec: add port property

[Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>]

Hello Dmitry,

On Tue, 29 Oct 2024 02:33:12 +0500
Dmitry Yashin <dmt.yashin@xxxxxxxxx> wrote:

> Fix DTB warnings when rk3308-codec used with audio-graph-card by
> documenting port property:
> 
> codec@ff560000: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Dmitry Yashin <dmt.yashin@xxxxxxxxx>
> ---
>  .../devicetree/bindings/sound/rockchip,rk3308-codec.yaml      | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml b/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
> index ecf3d7d968c8..2cf229a076f0 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
> @@ -48,6 +48,10 @@ properties:
>        - const: mclk_rx
>        - const: hclk
>  
> +  port:
> +    $ref: audio-graph-port.yaml#
> +    unevaluatedProperties: false

Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

Also, why not adding a 'port' node to the example below? Can be done in
v2 in case you send one.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com