Re: [PATCH] ASoC: codecs: rt5640: Always disable IRQs from rt5640_cancel_work()

[Mark Brown <broonie@xxxxxxxxxx>]

On Thu, 24 Oct 2024 23:56:12 +0200, Hans de Goede wrote:
> Disable IRQs from rt5640_cancel_work(), this fixes a crash caused by
> the IRQ never getting freed when the driver is unbound from the i2c_client
> with jack-detection active:
> 
> [  193.138780] rt5640 i2c-rt5640: ASoC: unknown pin LDO2
> [  193.138830] rt5640 i2c-rt5640: ASoC: unknown pin MICBIAS1
> [  193.671218] BUG: kernel NULL pointer dereference, address: 0000000000000078
> [  193.671239] #PF: supervisor read access in kernel mode
> [  193.671248] #PF: error_code(0x0000) - not-present page
> ...
> [  193.671531]  ? asm_exc_page_fault+0x22/0x30
> [  193.671551]  ? rt5640_jack_inserted+0x10/0x80 [snd_soc_rt5640]
> [  193.671574]  rt5640_detect_headset+0x93/0x130 [snd_soc_rt5640]
> [  193.671596]  rt5640_jack_work+0x93/0x355 [snd_soc_rt5640]
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: rt5640: Always disable IRQs from rt5640_cancel_work()
      commit: 032532f91a1d06d0750f16c49a9698ef5374a68f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark