Re: [PATCH v6] ALSA: compress_offload: introduce accel operation mode

[Jaroslav Kysela <perex@xxxxxxxx>]

On 23. 10. 24 7:27, Vinod Koul wrote:
> Hi Jaroslav,
>
> On 02-10-24, 11:39, Jaroslav Kysela wrote:
> > There is a requirement to expose the audio hardware that accelerates various
> > tasks for user space such as sample rate converters, compressed
> > stream decoders, etc.
> >
> > This is description for the API extension for the compress ALSA API which
> > is able to handle "tasks" that are not bound to real-time operations
> > and allows for the serialization of operations.
>
> This lgtm, but I found one thing missing. I think we had
> discussed that we might want to call the devices with accel api not
> ComprCxDy but something else? Can we add that.. maybe accelCxDy instead
> as both are mutually exclusive

There is a problem when CONFIG_SND_DYNAMIC_MINORS is not set (static minor 
numbers assignment). I don't see it as an issue, because the accel api 
requires O_RDWR for open which is new requirement. Old code will obtain an 
open error for this device. Also note that SND_COMPRESS_PLAYBACK and 
SND_COMPRESS_CAPTURE is selected based on those open flags, so the device 
enumeration works already with this assumption.

						Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.