Re: [PATCH] ASoC: tegra: Add support for S24_LE audio format

[Sameer Pujar <spujar@xxxxxxxxxx>]

On 22-10-2024 09:43, Sheetal . wrote:
> From: Ritu Chaudhary <rituc@xxxxxxxxxx>
>
> Add support for S24_LE format for all internal and IO AHUB
> modules, except for ASRC (which is already supported).
>
> The data flow happens as mentioned below:
>
> - ADMAIF picks 24-bit valid data and converts it to 32-bit before
>    sending to internal AHUB modules. This makes the driver change
>    simpler for internal AHUB modules.
> - IO modules CIF converts the 32-bit data to 24-bit before sending it
>    to the external world.
> - To maintain consistency across modules, conversions between 24-bit
>    and 32-bit occur either at ADMAIF or at the IO modules CIF.
>
> This feature has been thoroughly tested and verified with all internal
> AHUB modules on the Jetson AGX Orin Platform, as well as with the
> external RT5640 codec.
>
> Signed-off-by: Ritu Chaudhary <rituc@xxxxxxxxxx>
> Signed-off-by: Sheetal <sheetal@xxxxxxxxxx>
> ---
>   sound/soc/tegra/tegra186_dspk.c   |  3 +++
>   sound/soc/tegra/tegra210_admaif.c | 11 +++++++++--
>   sound/soc/tegra/tegra210_adx.c    |  9 +++++++--
>   sound/soc/tegra/tegra210_amx.c    |  9 +++++++--
>   sound/soc/tegra/tegra210_dmic.c   |  7 +++++--
>   sound/soc/tegra/tegra210_i2s.c    | 14 ++++++++++++--
>   sound/soc/tegra/tegra210_i2s.h    |  9 +++++----
>   sound/soc/tegra/tegra210_mixer.c  |  9 +++++++--
>   sound/soc/tegra/tegra210_mvc.c    |  9 +++++++--
>   sound/soc/tegra/tegra210_ope.c    |  9 +++++++--
>   sound/soc/tegra/tegra210_sfc.c    |  9 +++++++--
>   11 files changed, 76 insertions(+), 22 deletions(-)

Reviewed-by: Sameer Pujar <spujar@xxxxxxxxxx>