Re: [PATCH] ASoC: loongson: make loongson-i2s.o a separate module

["Arnd Bergmann" <arnd@xxxxxxxx>]

On Wed, Oct 16, 2024, at 06:56, 周彬彬 wrote:
>> -----Original Messages-----
>> From: "Arnd Bergmann" <arnd@xxxxxxxxxx>
>> Send time:Tuesday, 10/15/2024 23:09:54
>> To: "Liam Girdwood" <lgirdwood@xxxxxxxxx>, "Mark Brown" <broonie@xxxxxxxxxx>, "Jaroslav Kysela" <perex@xxxxxxxx>, "Takashi Iwai" <tiwai@xxxxxxxx>, "Binbin Zhou" <zhoubinbin@xxxxxxxxxxx>
>> Cc: "Arnd Bergmann" <arnd@xxxxxxxx>, tangbin <tangbin@xxxxxxxxxxxxxxxxxxxx>, linux-sound@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
>> Subject: [PATCH] ASoC: loongson: make loongson-i2s.o a separate module
>> 
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>> 
>> An object file should not be linked into multiple modules and/or
>> vmlinux:
>> 
>> scripts/Makefile.build:221: /home/arnd/arm-soc/sound/soc/loongson/Makefile: loongson_i2s.o is added to multiple modules: snd-soc-loongson-i2s-pci snd-soc-loongson-i2s-plat
>
> I would like to ask for some advice.
> I didn't notice this warning before when I submitted the patch, is 
> there some specific compilation option that needs to be turned on?

I think this is one of the warnings that are currently
only enabled when building with "make W=1". I have this enabled
by default as I hope to make it a default warning soon.

In general, I would recommend to build new driver code with W=1
before submitting. 

     Arnd