Re: [PATCH v7 0/9] of: property: add of_graph_get_next_port/port_endpoint()

[Helge Deller <deller@xxxxxx>]

On 10/15/24 17:49, Rob Herring wrote:
> On Wed, Oct 09, 2024 at 01:44:30AM +0000, Kuninori Morimoto wrote:
> > Hi Rob, Saravana, Tomi, Laurent, Sakari, Mark
> >
> > This is v7 patch-set
> >
> > Current Of-graph has "endpoint base" for loop, but doesn't have
> > "port base" loop. "endpoint base" loop only is not enough.
> > This patch-set add new "port base" for loop, and use it.
> >
> > v6 -> v7
> > 	- based on latest linus/master branch
> > 	- remove "ports" base functions
> > 	- use "port" base function on "endpoint" function ([3/9])
> > 	- tidyup [1/9] explanation
> >
> > v5 -> v6
> > 	- based on latest linus/master branch
> > 	- [9/9]: fixed compile warrning
> >
> > v4 -> v5
> > 	- tidyup comments
> > 	- [8/9]: parent NULL check was removed
> > 	- [9/9]: use for_each_of_graph_port()
> >
> > v3 -> v4
> > 	- new for_each loop includes __free()
> > 	 - comment indicates to use return_ptr() or no_free_ptr() if
> > 	   it need to continue to use node
> > 	 - each driver based on it
> > 	- care "prev" leak on of_graph_get_next_ports()
> > 	- of_graph_get_next_port_endpoint() indicates WARN() if port
> > 	  has non-endpoint node
> > 	- tidyup each git-log
> >
> > v2 -> v3
> > 	- return NULL if it it doesn't have ports / port
> > 	- add visible comment on of_graph_get_next_ports()
> >
> > v1 -> v2
> > 	- add each Reviewed-by / Acked-by
> > 	- tidyup/update Kernel Docs
> > 	- use prev as parameter
> > 	- update git-log explanation
> > 	- remove extra changes
> >
> > Kuninori Morimoto (9):
> >    of: property: add of_graph_get_next_port()
> >    of: property: add of_graph_get_next_port_endpoint()
> >    of: property: use new of_graph functions
> >    ASoC: test-component: use new of_graph functions
> >    ASoC: audio-graph-card: use new of_graph functions
> >    ASoC: audio-graph-card2: use new of_graph functions
> >    gpu: drm: omapdrm: use new of_graph functions
> >    fbdev: omapfb: use new of_graph functions
> >    media: xilinx-tpg: use new of_graph functions
>
> The DT parts look fine to me now. I see Mark acked this so he's not
> expecting to take it. I can take it,

Speaking for fbdev, I'd be happy if you take them.

> but need acks on the fbdev and media patches.

I just sent Ack for fbdev/drm.

Helge