RE: [EXTERNAL] Re: [PATCH v1] Upload dsp firmware for ASUS laptop 1EB30 & 1EB31 and Update WHENCE for both

["Ding, Shenghao" <shenghao-ding@xxxxxx>]

Hi Mario
Thanks for review, I met some trouble on "make check".  Kindly do me a favor.
The detail is inline.

> -----Original Message-----
> From: Mario Limonciello <superm1@xxxxxxxxx>
> Sent: Thursday, October 10, 2024 11:06 AM
> To: Ding, Shenghao <shenghao-ding@xxxxxx>; linux-firmware@xxxxxxxxxx
> Cc: Xu, Baojun <baojun.xu@xxxxxx>; derekjohn.clark@xxxxxxxxx;
> 13916275206@xxxxxxx; romangg@xxxxxxxxxxx; linux-sound@xxxxxxxxxxxxxxx;
> Chen, Robin <robinchen@xxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Yi, Ken <k-
> yi@xxxxxx>; Navada Kanyana, Mukund <navada@xxxxxx>; philm@xxxxxxxxxxx;
> jlobue10@xxxxxxxxx; luke@xxxxxxxxxx; antheas.dk@xxxxxxxxx
> Subject: [EXTERNAL] Re: [PATCH v1] Upload dsp firmware for ASUS laptop
> 1EB30 & 1EB31 and Update WHENCE for both
> 
> 
> On 10/9/24 05:18, Shenghao Ding wrote:
> > Signed-off-by: Shenghao Ding <shenghao-ding@xxxxxx>
> > ---
> >   WHENCE                     |   4 ++++
> >   ti/tas2781/TAS2XXX2234.bin | Bin
> >   2 files changed, 4 insertions(+)
> >   mode change 100644 => 100755 ti/tas2781/TAS2XXX2234.bin
> >
> > diff --git a/WHENCE b/WHENCE
> > index a9c8bb5..00096eb 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -7487,6 +7487,8 @@ Originates from
> Hello,
> 
> I tried to process this into a MR on Gitlab and it failed CI.
> 
> https://urldefense.com/v3/__https://gitlab.com/kernel-firmware/linux-
> firmware/-
> /merge_requests/311__;!!G3vK!T_f_IGXhtmSFR7P6UYZ14805X_k8seqk3G5386
> 2lXRJssIwKLs1Hegcn8NKMnqC9UGSPGCZ_lYOpoDo$
> 
> Please run 'make check' before submitting.
Although TAS2XXX1EB30.bin and TAS2XXX1EB31.bin are both in ti/tas2781, yet it reported "does not exist".
I have no idea why the file is there while report "does not exist". After I removed the newly-merged, no such report.

Following is the log. 

root@LAPTOP-70RJ5B8Q:/usr/local/src/fw_new# make check
Check that executables have shebangs.....................................Passed
Forbid new submodules....................................................Passed
Check Yaml...............................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Detect Destroyed Symlinks................................................Passed
shellcheck...............................................................Passed
black....................................................................Passed
markdownlint.............................................................Failed
- hook id: markdownlint
- exit code: 1

internal/modules/cjs/loader.js:818
  throw err;
  ^

Error: Cannot find module 'node:fs'
Require stack:
- /root/.cache/pre-commit/repoxl59c0uz/node_env-system/lib/node_modules/markdownlint-cli/markdownlint.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:85:18)
    at Object.<anonymous> (/root/.cache/pre-commit/repoxl59c0uz/node_env-system/lib/node_modules/markdownlint-cli/markdownlint.js:5:12)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/root/.cache/pre-commit/repoxl59c0uz/node_env-system/lib/node_modules/markdownlint-cli/markdownlint.js'
  ]
}

Check whence.............................................................Failed
- hook id: check-whence
- exit code: 1

E: ti/tas2781/TAS2XXX1EB30.bin listed in WHENCE does not exist
E: ti/tas2781/TAS2XXX1EB31.bin listed in WHENCE does not exist
E: target ti/tas2781/TAS2XXX1EB30.bin of link TAS2XXX1EB30.bin in WHENCE does not exist
E: target ti/tas2781/TAS2XXX1EB31.bin of link TAS2XXX1EB31.bin in WHENCE does not exist

make: *** [Makefile:10: check] Error 1
root@LAPTOP-70RJ5B8Q:/usr/local/src/fw_new# ls ti/tas2781/TAS2XXX1* -al
-rw-r--r-- 1 root root 35220 Sep 28 21:54 ti/tas2781/TAS2XXX1EB30.bin
-rw-r--r-- 1 root root 35220 Sep 28 21:55 ti/tas2781/TAS2XXX1EB31.bin
root@LAPTOP-70RJ5B8Q:/usr/local/src/fw_new#
> 
> Thanks,