Re: [PATCH v2?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp_status function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



How do you think about to replace the word “function” (in the summary phrase)
by parentheses?


> Added proper error handling for register value check that

  Add?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94


> return -EPERM when register value does not meet expected condition

* It is usually preferred to end such a sentence with a dot, isn't it?

* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?


…
> ---
>  sound/soc/codecs/aw88399.c | 2 +-

Please take version information better into account.

See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n321

* https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22


Regards,
Markus





[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux