Re: [PATCH 6/6] arm64: dts: allwinner: h616: Add audio codec node

[Andre Przywara <andre.przywara@xxxxxxx>]

On Sun, 29 Sep 2024 23:06:07 +1300
Ryan Walklin <ryan@xxxxxxxxxxxxx> wrote:

Hi Ryan,

> Now that the sun4i codec driver supports the H616, add a node in the
> device tree for it.

Can you please add another patch that actually enables the codec for at
least one board? Is that really just status = "okay";? Or do we need
simple-soundcard nodes still?
I will try to give it a test on the H61* boards I have, and would then
like those boards to be enabled as well, as part of this series. Otherwise
it's somewhat of a dead feature, isn't it?

Cheers,
Andre

> Signed-off-by: Ryan Walklin <ryan@xxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> index e88c1fbac6acc..006fdb7e7e0ae 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> @@ -645,6 +645,21 @@ spdif: spdif@5093000 {
>  			status = "disabled";
>  		};
>  
> +		codec: codec@05096000 {
> +			#sound-dai-cells = <0>;
> +			compatible = "allwinner,sun50i-h616-codec";
> +			reg = <0x05096000 0x31c>;
> +			interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&ccu CLK_BUS_AUDIO_CODEC>,
> +				 <&ccu CLK_AUDIO_CODEC_1X>,
> +				 <&ccu CLK_AUDIO_CODEC_4X>;
> +			clock-names = "apb", "codec", "audio-codec-4x";
> +			resets = <&ccu RST_BUS_AUDIO_CODEC>;
> +			dmas = <&dma 6>;
> +			dma-names = "tx";
> +			status = "disabled";
> +		};
> +
>  		gpadc: adc@5070000 {
>  			compatible = "allwinner,sun50i-h616-gpadc",
>  				     "allwinner,sun20i-d1-gpadc";