Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()

[Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>]

On Thu, Oct 03, 2024 at 10:27:39AM GMT, Gax-c wrote:
> From: Zichen Xie <zichenxie0106@xxxxxxxxx>
> 
> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could
> possibly return NULL pointer. NULL Pointer Dereference may be
> triggerred without addtional check.
> Add a NULL check for the returned pointer.
> 
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers")
> Signed-off-by: Zichen Xie <zichenxie0106@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

I think Fixes / Cc / Signed-off-by is more logical.

> ---
>  sound/soc/qcom/lpass-cpu.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

This is version two of your patch (even though the patch contents didn't
change). Please tag your patches accordingly, provide a changelog and
don't send next iteration as a reply to the existing thread (it might
get lost or mishandled). Please send a proper v3 of your patch.

-- 
With best wishes
Dmitry