On Mon, Sep 30, 2024 at 10:29:08AM +0300, Maxim Mikityanskiy wrote: > Anyways, adding a DMI check to hda_intel or quirk_nvidia_hda seems the > same level of efforts, so I can proceed with the former. It's the same > power consumption either way, right? > > I'm also thinking of adding a module parameter to block probing of the > DGPU audio. Back in the days, there were plenty of similar Lenovo > laptops, which might also suffer from the same issue. Adding new command line parameters for hardware quirks is generally frowned upon these days and is usually greeted by Greg KH's trademark "this isn't the 1990s anymore" comment. Drivers are supposed to auto-detect hardware with quirks and handle them correctly without the user having to add a command line option. Users should not get accustomed to fiddling with the command line. They won't have the need to report broken hardware and the driver may never be amended to deal with affected models automatically. Thanks, Lukas
- References:
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Takashi Iwai
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Maxim Mikityanskiy
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Takashi Iwai
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Maxim Mikityanskiy
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Takashi Iwai
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Maxim Mikityanskiy
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Takashi Iwai
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Maxim Mikityanskiy
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Takashi Iwai
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- From: Maxim Mikityanskiy
- Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- Prev by Date: Re: Add stacked and parallel memories support in spi-nor
- Next by Date: Re: [PATCH v2 2/2] arm64: dts: mediatek: mt6359: fix dtbs_check error for audio-codec
- Previous by thread: Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- Next by thread: Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
- Index(es):