Re: [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200

[Abhishek Tamboli <abhishektamboli9@xxxxxxxxx>]

Hi Shuah,
Thanks for the feedback.

On Thu, Sep 26, 2024 at 10:12:03AM -0600, Shuah Khan wrote:
> On 9/26/24 09:51, Abhishek Tamboli wrote:
> > Add the quirk for HP Pavilion Gaming laptop 15z-ec200 for
> > enabling the mute led. The fix apply the ALC285_FIXUP_HP_MUTE_LED
> > quirk for this model.
> 
> Were you able to test  this on HP Pavilion Gaming laptop? If so
> please add that to the change log.
The person who reported the bug confirmed that the patch resolved 
the issue on his device. 
For your reference: https://bugzilla.kernel.org/show_bug.cgi?id=219303

> > Signed-off-by: Abhishek Tamboli <abhishektamboli9@xxxxxxxxx>
> > ---
> >   sound/pci/hda/patch_realtek.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 4ca66234e561..94125a977f08 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -10315,6 +10315,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> >   	SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> >   	SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> >   	SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> > +	SND_PCI_QUIRK(0x103c, 0x88DD, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
> >   	SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> >   	SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> >   	SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> 
> Looks like this has been fixed:
> 
> https://lore.kernel.org/lkml/20220918171300.24693-1-dhould3@xxxxxxxxx/t/#m0c6aeebe5cc89c9a4228d49f56f4a0a4c516e012
No, this patch seems to be for the HP OMEN 16. 

Thanks,
Abhishek