Re: [PATCH v2 2/9] ASoC: codecs: Add support for ES8323

[Binbin Zhou <zhoubb.aaron@xxxxxxxxx>]

Hi Mark:

On Tue, Sep 24, 2024 at 3:04 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Tue, Sep 24, 2024 at 03:00:19PM +0800, Binbin Zhou wrote:
>
> > +     /* interface format */
> > +     switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> > +     case SND_SOC_DAIFMT_I2S:
> > +             adciface &= 0xFC;
> > +             daciface &= 0xF9;
> > +             break;
> > +     case SND_SOC_DAIFMT_RIGHT_J:
> > +     case SND_SOC_DAIFMT_LEFT_J:
> > +     case SND_SOC_DAIFMT_DSP_A:
> > +     case SND_SOC_DAIFMT_DSP_B:
> > +             break;
>
> This results in an identical configuration for everything except I2S
> which must be buggy, these are distinct formats in ways that are visible
> on the bus.

Ok, I checked the datasheet for the ES8323 and it has set bits for
LEFT_J/RIGHT_J etc.
In the next version, I'll patch it all.

Thanks.
Binbin