On 9/20/24 09:27, Shuah Khan wrote:
On 9/19/24 15:49, Abdul Rahim wrote:
On Thu, Sep 19, 2024 at 09:40:34AM GMT, Shuah Khan wrote:
On 9/15/24 17:41, Abdul Rahim wrote:
When ALSA is not installed on the users system, the error:
"Package alsa was not found in the pkg-config search path.
Perhaps you should add the directory containing `alsa.pc'
to the PKG_CONFIG_PATH environment variable
Package 'alsa', required by 'virtual:world', not found"
extra line?
is printed 3 times, which generates unnecessary noise.
Hence, Remove unnecessary noise using `--silence-errors` on LDLIBS
assignment, so the message is printed only once.
I would say this message is alerting the user that the package is missing.
Why would you want to delete it?
Signed-off-by: Abdul Rahim <abdul.rahim@xxxxxxxxxxx>
---
tools/testing/selftests/alsa/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/alsa/Makefile b/tools/testing/selftests/alsa/Makefile
index 25be68025290..cd022fc869fb 100644
--- a/tools/testing/selftests/alsa/Makefile
+++ b/tools/testing/selftests/alsa/Makefile
@@ -2,7 +2,7 @@
#
CFLAGS += $(shell pkg-config --cflags alsa) $(KHDR_INCLUDES)
-LDLIBS += $(shell pkg-config --libs alsa)
+LDLIBS += $(shell pkg-config --silence-errors --libs alsa)
ifeq ($(LDLIBS),)
LDLIBS += -lasound
endif
thanks,
-- Shuah
This can also be handled like this:
---
CHECK := $(shell pkg-config --exists alsa; echo $?)
ifneq ($(CHECK),0)
$(error Package alsa not found! Add directory containing alsa.pc in PKG_CONFIG_PATH)
endif
---
This is a better solution than suppressing errors.
One more thing. "make kselftest-all" has to continue even if this error causes alsa
compile to fail.
thanks,
-- Shuah
[Index of Archives]
[Pulseaudio]
[Linux Audio Users]
[ALSA Devel]
[Fedora Desktop]
[Fedora SELinux]
[Big List of Linux Books]
[Yosemite News]
[KDE Users]
