Re: [PATCH] ASoc: mediatek: mt8365: Print the ret value

[AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>]

Il 11/09/24 13:19, Muhammad Usama Anjum ha scritto:
> Print the ret value otherwise it is just being set without ever getting
> used. The author may have missed printing it.
>
> Fixes: 1bf6dbd75f76 ("ASoc: mediatek: mt8365: Add a specific soundcard for EVK")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
> ---
> If it isn't useful, the ret value assignment statement can be removed.

Nah, please just remove the ret assignment... and while you're at it, can you also
change that dev_warn() to dev_info()?

That print is actually expected to be seen on some boards, and it may, or may not,
be something to be warned about; this is because some the states are optional, or
actually the only requirement is to have at least one pin group muxed to audio but
not forcefully a specific one (so you may have i2s0 on a board, i2s1 on the other).

Cheers,
Angelo


> ---
>   sound/soc/mediatek/mt8365/mt8365-mt6357.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/mediatek/mt8365/mt8365-mt6357.c b/sound/soc/mediatek/mt8365/mt8365-mt6357.c
> index fef76118f8010..412f5fdd8fc52 100644
> --- a/sound/soc/mediatek/mt8365/mt8365-mt6357.c
> +++ b/sound/soc/mediatek/mt8365/mt8365-mt6357.c
> @@ -258,8 +258,8 @@ static int mt8365_mt6357_gpio_probe(struct snd_soc_card *card)
>   							   mt8365_mt6357_pin_str[i]);
>   		if (IS_ERR(priv->pin_states[i])) {
>   			ret = PTR_ERR(priv->pin_states[i]);
> -			dev_warn(card->dev, "No pin state for %s\n",
> -				 mt8365_mt6357_pin_str[i]);
> +			dev_warn(card->dev, "No pin state(%d) for %s\n",
> +				 ret, mt8365_mt6357_pin_str[i]);
>   		} else {
>   			ret = pinctrl_select_state(priv->pinctrl,
>   						   priv->pin_states[i]);