Re: [PATCH] ASoC: mt8365: Fix using uninitialized value "i2s_data" issue

[Mark Brown <broonie@xxxxxxxxxx>]

On Wed, Sep 11, 2024 at 08:15:17AM +0800, Qianqiang Liu wrote:

>  
>  	spin_lock_irqsave(&afe_priv->afe_ctrl_lock, flags);
>  
> +	if (!i2s_data) {
> +		spin_unlock_irqrestore(&afe_priv->afe_ctrl_lock, flags);
> +		return;
> +	}
> +

Why would we look up i2s_data without the lock, take the lock, then
check if we actually found it?  That doesn't seem right.

Attachment: signature.asc
Description: PGP signature