Re: [PATCH] ASoC: mediatek: mt8365: include linux/bitfield.h

[Matthias Brugger <matthias.bgg@xxxxxxxxxx>]

On 09/09/2024 00:17, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> On x86, the header is not already included implicitly,
> breaking compile-testing:
>
> In file included from sound/soc/mediatek/mt8365/mt8365-afe-common.h:19,
>                   from sound/soc/mediatek/mt8365/mt8365-afe-pcm.c:18:
> sound/soc/mediatek/mt8365/mt8365-afe-pcm.c: In function 'mt8365_afe_cm2_mux_conn':
> sound/soc/mediatek/mt8365/mt8365-reg.h:952:41: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
>    952 | #define CM2_AFE_CM2_CONN_CFG1(x)        FIELD_PREP(CM2_AFE_CM2_CONN_CFG1_MASK, (x))
>        |                                         ^~~~~~~~~~
>
> Included it ahead of the field definitions.
>
> Fixes: 38c7c9ddc740 ("ASoC: mediatek: mt8365: Add common header")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>

> ---
>
> This started happening after I applied "ASoC: mt8365: Allow build coverage".
> ---
>   sound/soc/mediatek/mt8365/mt8365-reg.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/mediatek/mt8365/mt8365-reg.h b/sound/soc/mediatek/mt8365/mt8365-reg.h
> index b763cddc93db..4ebbb94ff02e 100644
> --- a/sound/soc/mediatek/mt8365/mt8365-reg.h
> +++ b/sound/soc/mediatek/mt8365/mt8365-reg.h
> @@ -10,6 +10,8 @@
>   #ifndef _MT8365_REG_H_
>   #define _MT8365_REG_H_
>   
> +#include <linux/bitfield.h>
> +
>   #define AUDIO_TOP_CON0			(0x0000)
>   #define AUDIO_TOP_CON1			(0x0004)
>   #define AUDIO_TOP_CON2			(0x0008)