Re: [PATCH] ASoC: codecs: fix the right check and simplify code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



> In the file drivers/base/platform.c, the return description of
> platform_get_irq is 'non-zero IRQ number on success, negative
> error number on failure.', so the check is wrong, fix it. And
> when get irq failed, the function platform_get_irq logs an error
> message.

1. You may occasionally put more than 64 characters into text lines
   of such a change description.

2. How do you think about to split any changes into separate update steps?
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6#n81

3. I find the wording “fix the right check” confusing.


Regards,
Markus





[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux