Re: [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk

[Takashi Iwai <tiwai@xxxxxxx>]

On Fri, 06 Sep 2024 23:14:38 +0200,
Joshua Pius wrote:
> 
> Specify shortnames for the following Logitech Devices: Rally bar, Rally
> bar mini, Tap, MeetUp and Huddle.
> 
> Signed-off-by: Joshua Pius <joshuapius@xxxxxxxxxx>

Is this change needed only for UCM profiles?  UCM v2 should be able to
handle better to identify models, and such short name updates aren't
needed for them.

OTOH, I don't mind much to take this kind of small harmless changes
(unless it happens too frequently).  So I'll likely take this, but
just for verifying the situation.


thanks,

Takashi


> ---
>  sound/usb/card.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/sound/usb/card.c b/sound/usb/card.c
> index 778de9244f1e..9c411b82a218 100644
> --- a/sound/usb/card.c
> +++ b/sound/usb/card.c
> @@ -384,6 +384,12 @@ static const struct usb_audio_device_name usb_audio_names[] = {
>  	/* Creative/Toshiba Multimedia Center SB-0500 */
>  	DEVICE_NAME(0x041e, 0x3048, "Toshiba", "SB-0500"),
>  
> +	/* Logitech Audio Devices */
> +	DEVICE_NAME(0x046d, 0x0867, "Logitech, Inc.", "Logi-MeetUp"),
> +	DEVICE_NAME(0x046d, 0x0874, "Logitech, Inc.", "Logi-Tap-Audio"),
> +	DEVICE_NAME(0x046d, 0x087c, "Logitech, Inc.", "Logi-Huddle"),
> +	DEVICE_NAME(0x046d, 0x0898, "Logitech, Inc.", "Logi-RB-Audio"),
> +	DEVICE_NAME(0x046d, 0x08d2, "Logitech, Inc.", "Logi-RBM-Audio"),
>  	DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"),
>  
>  	DEVICE_NAME(0x05e1, 0x0408, "Syntek", "STK1160"),
> -- 
> 2.46.0.598.g6f2099f65c-goog
>