Re: [PATCH v1 07/10] ASoC: dt-bindings: Add Loongson I2S controller

[Binbin Zhou <zhoubb.aaron@xxxxxxxxx>]

Hi Krzysztof:

Thanks for your reply.

On Fri, Sep 6, 2024 at 4:23 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Thu, Sep 05, 2024 at 03:02:56PM +0800, Binbin Zhou wrote:
> > Add Loongson I2S controller binding with DT schema format using
> > json-schema.
> >
> > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
> > ---
> >  .../bindings/sound/loongson,ls2k-i2s.yaml     | 66 +++++++++++++++++++
> >  1 file changed, 66 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/sound/loongson,ls2k-i2s.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/loongson,ls2k-i2s.yaml b/Documentation/devicetree/bindings/sound/loongson,ls2k-i2s.yaml
> > new file mode 100644
> > index 000000000000..a2e3bbe00dab
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/loongson,ls2k-i2s.yaml
>
> Filename matching compatible.

I will rename it as loongson,ls2k1000-i2s.yaml
>
> > @@ -0,0 +1,66 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/loongson,ls2k-i2s.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Loongson-2K I2S controller
> > +
> > +maintainers:
> > +  - Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: dai-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: loongson,ls2k1000-i2s
> > +
> > +  reg:
> > +    maxItems: 2
>
> List and describe items instead.

OK..
>
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  dmas:
> > +    maxItems: 2
> > +
> > +  dma-names:
> > +    items:
> > +      - const: tx
> > +      - const: rx
> > +
> > +  '#sound-dai-cells':
> > +    const: 0
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - dmas
> > +  - dma-names
> > +  - '#sound-dai-cells'
> > +
> > +additionalProperties: false
>
> Instead:
> unevaluatedProperties: false

OK...

Thanks.
Binbin
>
> Best regards,
> Krzysztof
>