On Thu, Sep 05, 2024 at 03:02:54PM +0800, Binbin Zhou wrote: > This patch attempts to clean up driver code formatting issues. > Mainly as follows: > 1. Use the BIT macro; > 2. Use dev_err_probe() in every error path in probe in loongson_card > driver; > 3. Introduce loongson_card_acpi_find_device() to streamlined code. Please split these out into three separate patches to make them easier to review. I see there's also some other code reordering and reformatting in there which should also be split out separately. I think the changes are probably good overall but there's too much different stuff going on in one patch to check properly.
Attachment:
signature.asc
Description: PGP signature
- Follow-Ups:
- Re: [PATCH v1 05/10] ASoC: loongson: Improve code readability
- From: Binbin Zhou
- Re: [PATCH v1 05/10] ASoC: loongson: Improve code readability
- References:
- [PATCH v1 00/10] ASoC: Some issues about loongson i2s
- From: Binbin Zhou
- [PATCH v1 05/10] ASoC: loongson: Improve code readability
- From: Binbin Zhou
- [PATCH v1 00/10] ASoC: Some issues about loongson i2s
- Prev by Date: Re: [PATCH] ALSA: hda/realtek - Fix inactive headset mic jack for ASUS Vivobook 15 X1504VAP
- Next by Date: Re: [PATCH v1 08/10] ASoC: loongson: Add I2S controller driver as platform device
- Previous by thread: [PATCH v1 05/10] ASoC: loongson: Improve code readability
- Next by thread: Re: [PATCH v1 05/10] ASoC: loongson: Improve code readability
- Index(es):