Re: [PATCH] ALSA: pcm: Fix the previous conversion to kstrtoul()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]





On 2024/9/1 21:45, Takashi Iwai wrote:
The previous replacement from simple_strtoul() to kstrtoul() forgot
that the passed pointer must be an unsigned long int pointer, while
the value used there is a sized_t pointer.  Fix it.

Fixes: 61bc4deff033 ("ALSA: pcm: replace simple_strtoul to kstrtoul")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202409010425.YPS7cWeJ-lkp@xxxxxxxxx/
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
---
  sound/core/pcm_memory.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/pcm_memory.c b/sound/core/pcm_memory.c
index 73d4fc49a0ca..5001181208df 100644
--- a/sound/core/pcm_memory.c
+++ b/sound/core/pcm_memory.c
@@ -183,7 +183,7 @@ static void snd_pcm_lib_preallocate_proc_write(struct snd_info_entry *entry,
  	struct snd_pcm_substream *substream = entry->private_data;
  	struct snd_card *card = substream->pcm->card;
  	char line[64], str[64];
-	size_t size;
+	unsigned long size;

Sorry, I haven't noticed this.

Reviewed-by: Hongbo Li <lihongbo22@xxxxxxxxxx>
  	struct snd_dma_buffer new_dmab;
guard(mutex)(&substream->pcm->open_mutex);




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux