Re: [PATCH v1] cirrus: Simplify with dev_err_probe()

[Thomas Gleixner <tglx@xxxxxxxxxxxxx>]

On Wed, Aug 28 2024 at 15:59, Richard Fitzgerald wrote:
> On 28/08/2024 15:47, Thomas Gleixner wrote:
>> On Wed, Aug 28 2024 at 13:27, Charles Keepax wrote:
>>> Since we are doing a respin anyway also the brackets on the if
>>> should be dropped on both of these as well.
>> 
>> No. https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
>
> https://www.kernel.org/doc/html/latest/process/coding-style.html#codingstyle
>
> does not say that. It says:
>
> "Do not unnecessarily use braces where a single statement will do."
>
> Note: single statement, not single line.
>
> coding-style.rst is the coding style. If you disagree with the coding
> style, send a patch to change coding-style.rst.

There will never be an agreement about this, but for code which I
maintain and goes through the tip tree, the single line rule applies
simply because it's my time wasted when I can't parse code fluently.

Thanks,

        tglx