Re: [PATCH] ASoC: dt-bindings: Add dt bindings definition file for imx28 saif

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Tue, Aug 27, 2024 at 08:05:28PM +0200, Lukasz Majewski wrote:
> This file allows correct check of DTS node for imx287 based
> "fsl,imx28-saif" compatible device.
> 
> It corresponds to Documentation/devicetree/bindings/fsl,imx28-saif
> 
> Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
> ---
>  .../devicetree/bindings/sound/fsl,saif.yaml   | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)

There is a binding. Please perform conversion from TXT to DT schema,
mentioning in commit msg any changes from pure conversion (e.g. new
properties to match DTS).

Few more comments below.

>  create mode 100644 Documentation/devicetree/bindings/sound/fsl,saif.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl,saif.yaml b/Documentation/devicetree/bindings/sound/fsl,saif.yaml
> new file mode 100644
> index 000000000000..747faa411a50
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/fsl,saif.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/fsl,saif.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MXS Serial Audio Interface (SAIF)
> +
> +maintainers:
> +  - Lukasz Majewski <lukma@xxxxxxx>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The SAIF is based on I2S module that is used to communicate with audio codecs,
> +  but only with half-duplex manner (i.e. it can either transmit or receive PCM
> +  audio).
> +
> +properties:
> +  compatible:
> +    const: fsl,imx28-saif
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#sound-dai-cells":
> +    const: 0
> +
> +  assigned-clock-parents: true
> +  assigned-clock-rates: true
> +  assigned-clocks: true

These three should be dropped, redundant.

> +
> +  interrupts:
> +    maxItems: 1
> +
> +  dmas:
> +    maxItems: 1
> +
> +  dma-names:
> +    const: rx-tx
> +
> +  clocks:
> +    maxItems: 1
> +
> +  fsl,saif-master:
> +    description: Indicate that saif is a slave and its phandle points to master
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - dmas
> +  - dma-names
> +  - "#sound-dai-cells"

Keep the same order as in "properties:" block.

and here allOf: with $ref to dai-common.yaml

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    saif0: saif@80042000 {
> +        #sound-dai-cells = <0>;
> +        compatible = "fsl,imx28-saif";
> +        reg = <0x80042000 2000>;
> +        interrupts = <59>;
> +        clocks = <&clks 53>;
> +        dmas = <&dma_apbx 4>;
> +        dma-names = "rx-tx";
> +    };
> +  - |
> +    saif1: saif@80046000 {

Just one example, could be this one as more complete.

> +        #sound-dai-cells = <0>;

Keep it after "reg" (compatible and reg are always first).

Best regards,
Krzysztof