Re: [PATCH 3/3] arm64: dts: renesas: rzg2lc-smarc: Enable HDMI audio

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Biju,

On Thu, Jul 25, 2024 at 10:46 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Enable HDMI audio on RZ/G2LC SMARC EVK. Set SW 1.5 to OFF
> position on the SoM module to turn on HDMI audio.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> @@ -48,10 +58,16 @@ &canfd {
>  };
>  #endif
>
> +#if (!SW_I2S0_I2S1)
>  &cpu_dai {
>         sound-dai = <&ssi0>;
>  };
>
> +&ssi0 {
> +       /delete-node/ port;

Which submode does this delete?
The conditional one below which is only added when SW_I2S0_I2S1==1?

> +};
> +#endif
> +
>  &dsi {
>         status = "okay";
>

> @@ -177,6 +202,18 @@ &ssi0 {
>         pinctrl-names = "default";
>
>         status = "okay";
> +
> +#if (SW_I2S0_I2S1)
> +       i2s2_port: port {
> +               i2s2_cpu_endpoint: endpoint {
> +                       remote-endpoint = <&codec_endpoint>;
> +                       dai-format = "i2s";
> +
> +                       bitclock-master = <&i2s2_cpu_endpoint>;
> +                       frame-master = <&i2s2_cpu_endpoint>;
> +               };
> +       };
> +#endif
>  };
>
>  #if (SW_RSPI_CAN)

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds