Re: [PATCH 2/3] arm64: dts: renesas: rzg2l-smarc: Enable HDMI audio

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Biju,

On Thu, Jul 25, 2024 at 10:46 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Enable HDMI audio on RZ/{G2L,V2L} SMARC EVK.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc-pinfunction.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc-pinfunction.dtsi
> @@ -143,6 +143,13 @@ ssi0_pins: ssi0 {
>                          <RZG2L_PORT_PINMUX(45, 3, 1)>; /* RXD */
>         };
>
> +       ssi1_pins: ssi1 {
> +               pinmux = <RZG2L_PORT_PINMUX(46, 0, 1)>, /* BCK */
> +                        <RZG2L_PORT_PINMUX(46, 1, 1)>, /* RCK */
> +                        <RZG2L_PORT_PINMUX(46, 2, 1)>, /* TXD */
> +                        <RZG2L_PORT_PINMUX(46, 3, 1)>; /* RXD */

RXD/I2S2_SDIN is not wired on the carrier board.
OK to drop it?

The rest LGTM (but I'm no audio bindings expert).

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds