On Wed, Aug 21, 2024 at 11:02:21AM +0100, Richard Fitzgerald wrote: > If the timestamp of a calibration entry is 0 it is an unused entry and > must be ignored. > > Some end-products reserve EFI space for calibration entries by shipping > with a zero-filled EFI file. When searching the file for calibration > data the driver must skip the empty entries. The timestamp of a valid > entry is always non-zero. This breaks the build if I apply it on either for-6.11 or for-6.12: In file included from /build/stage/linux/sound/soc/codecs/cs-amp-lib-test.c:8: /build/stage/linux/sound/soc/codecs/cs-amp-lib-test.c: In function ‘cs_amp_lib_test_get_efi_cal_by_uid_test’: /build/stage/linux/sound/soc/codecs/cs-amp-lib-test.c:224:50: error: subscripted value is neither array nor pointer nor vector 224 | KUNIT_EXPECT_EQ(test, result_data.calTime[0], | ^ /build/stage/linux/include/kunit/test.h:724:22: note: in definition of macro ‘KUNIT_BASE_BINARY_ASSERTION’ 724 | const typeof(left) __left = (left); \ | ^~~~ (with lots more errors) - I'm guessins some missing dependency somewhere?
Attachment:
signature.asc
Description: PGP signature
- References:
- [PATCH] ASoC: cs-amp-lib: Ignore empty UEFI calibration entries
- From: Richard Fitzgerald
- [PATCH] ASoC: cs-amp-lib: Ignore empty UEFI calibration entries
- Prev by Date: Re: [PATCH] ALSA: core: Remove trigger_tstamp_latched
- Next by Date: Re: [PATCH -next 0/2] allow modules autoloading
- Previous by thread: [PATCH] ASoC: cs-amp-lib: Ignore empty UEFI calibration entries
- Next by thread: Re: [PATCH] ASoC: cs-amp-lib: Ignore empty UEFI calibration entries
- Index(es):