Re: [PATCH RESEND v2 1/6] ASoC: dt-bindings: midas-audio: Declare required properties for GPIO jack det

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 16.08.2024 09:50, Artur Weber wrote:
GPIO jack detection requires an IIO channel and the detection threshold
to work. Explicitly declare the requirement in DT schema.

Fixes: 0a590ecc672a ("ASoC: dt-bindings: samsung,midas-audio: Add GPIO-based headset jack detection")

Sorry, looks like the Reviewed-by tag from Rob Herring[1] didn't apply:

> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>

Best regards
Artur

[1] https://lore.kernel.org/all/172235554875.1349313.9208770866983277057.robh@xxxxxxxxxx/

Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx>
---
Changes in v2:
- Use anyOf instead of oneOf in headset-detect-gpios/headset-key-gpios
   if: statement
---
  .../bindings/sound/samsung,midas-audio.yaml        | 29 +++++++++++++++++++---
  1 file changed, 26 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
index 69ddfd4afdcd..5483421a6fd3 100644
--- a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
+++ b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
@@ -9,9 +9,6 @@ title: Samsung Midas audio complex with WM1811 codec
  maintainers:
    - Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
-allOf:
-  - $ref: sound-card-common.yaml#
-
  properties:
    compatible:
      const: samsung,midas-audio
@@ -102,6 +99,32 @@ required:
    - mic-bias-supply
    - submic-bias-supply
+allOf:
+  - $ref: sound-card-common.yaml#
+
+  - if:
+      anyOf:
+        - required: [ headset-detect-gpios ]
+        - required: [ headset-key-gpios ]
+    then:
+      required:
+        - io-channels
+        - io-channel-names
+
+  - if:
+      required:
+        - headset-detect-gpios
+    then:
+      required:
+        - samsung,headset-4pole-threshold-microvolt
+
+  - if:
+      required:
+        - headset-key-gpios
+    then:
+      required:
+        - samsung,headset-button-threshold-microvolt
+
  unevaluatedProperties: false
examples:






[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux