Re: [PATCH] ALSA: hda: cs35l56: Remove redundant call to hda_cs_dsp_control_remove()

[Takashi Iwai <tiwai@xxxxxxx>]

On Tue, 13 Aug 2024 13:07:50 +0200,
Richard Fitzgerald wrote:
> 
> The driver doesn't create any ALSA controls for firmware controls, so it
> shouldn't be calling hda_cs_dsp_control_remove().
> 
> commit 34e1b1bb7324 ("ALSA: hda: cs35l56: Stop creating ALSA controls for
> firmware coefficients") removed the call to hda_cs_dsp_add_controls() but
> didn't remove the call for destroying those controls.
> 
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> Fixes: 34e1b1bb7324 ("ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients")

Applied now.

I suppose you'll submit the fix for cs35l41, too?


thanks,

Takashi