Re: [PATCH] ALSA: hda/realtek: tas2781: Fix ROG ALLY X audio

[Takashi Iwai <tiwai@xxxxxxx>]

On Mon, 12 Aug 2024 06:53:25 +0200,
Jonathan LoBue wrote:
> 
> This patch enables the TI TAS2781 amplifier SoC for the ASUS ROG ALLY X.
> This is a design change from the original ASUS ROG ALLY, creating the need
> for this patch. All other Realtek Codec settings seem to be re-used from
> the original ROG ALLY design (on the ROG ALLY X). This patch maintains the
> previous settings for the Realtek codec portion, but enables the I2C
> binding for the TI TAS2781 amplifier (instead of the Cirrus CS35L41 amp
> used on the original ASUS ROG ALLY).
> 
> One other requirement must be met for audio to work on the ASUS ROG ALLY X.
> A proper firmware file in the correct location with a proper symlink. We
> had reached out to TI engineers and confirmed that the firmware found in
> the Windows' driver package has a GPL license. Bazzite Github is hosting
> this firmware file for now until proper linux-firmware upstreaming can
> occur. https://github.com/ublue-os/bazzite
> 
> This firmware file should be placed in
> /usr/lib/firmware/ti/tas2781/TAS2XXX1EB3.bin with a symlink to it from
> /usr/lib/firmware/TAS2XXX1EB3.bin
> 
> Co-developed by: Kyle Gospodnetich <me@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Kyle Gospodnetich <me@xxxxxxxxxxxxxxxxx>
> Co-developed by: Jan Drogehoff <sentrycraft123@xxxxxxxxx>
> Signed-off-by: Jan Drogehoff <sentrycraft123@xxxxxxxxx>
> Signed-off-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>
> Tested-by: Richard Alvarez <alvarez.richard@xxxxxxxxx>
> Tested-by: Miles Montierth <cyber_dopamine@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jonathan LoBue <jlobue10@xxxxxxxxx>

Applied to for-next branch.

Meanwhile, could you ask TI guys to include the missing firmware files
in linux-firmware git tree, too?


thanks,

Takashi